Model menus, modal edit and layout improvements

app/views/success_criteria/_body.html.slim

@@ -44,7 +44,7 @@
         .text-end.fw-bold = SuccessCriterion.human_attribute_name(:quick_fix)
       .col-md-8.col-lg-9
         = success_criterion.quick_fix
-    .row.mb-3
+    .row
       .col-md-4.col-lg-3
         .text-end.fw-bold   = SuccessCriterion.human_attribute_name(:test_instructions)
       .col-md-8.col-lg-9

app/views/success_criteria/_form.html.slim

@@ -6,4 +6,5 @@
   = form.rich_text_area :quick_fix
   = form.rich_text_area :test_comment
   = form.submit class: "btn btn-primary"
-  = link_to "Abbrechen", success_criterion.persisted? ? success_criterion : success_criterion.element, class: "btn btn-outline-secondary"
+- unless modal?
+  =< link_to "Abbrechen", success_criterion.persisted? ? success_criterion : success_criterion.element, class: "btn btn-outline-secondary"

app/views/success_criteria/_header.html.slim

@@ -19,4 +19,4 @@ summary.d-flex.align-items-start id=dom_id(success_criterion, :header)
       = success_criterion_badge(success_criterion.check.external_number, extra_classes: "text-bg-info me-1")
       
       = success_criterion_badge(success_criterion.level, extra_classes: "sc-level-#{success_criterion.level.to_s.downcase} me-1")
-    i.bi.bi-grip-vertical.handle
+    i.bi.bi-grip-vertical.handle.me-1

app/views/success_criteria/destroy.turbo_stream.slim

@@ -1,4 +1,6 @@
 = turbo_stream.remove dom_id(@success_criterion)
 - @success_criterion.element.success_criteria.reject { _1 == @success_criterion }.each do |sc|
   - Rails.logger.debug "Send to sc #{sc.id}"
-  = turbo_stream.update dom_id(sc, :position), "#{sc.page.position}.#{sc.element.position}.#{sc.position}"
+  = turbo_stream.update dom_id(sc, :position), "#{sc.page.position}.#{sc.element.position}.#{sc.position}"
+
+= turbo_stream_toast("Erfolgskriterium wurde gelöscht", true)

app/views/success_criteria/edit.html.slim

@@ -1,19 +1,7 @@
-h1
-  = t("scaffold.pagetitle_edit", model: SuccessCriterion.model_name.human)
-= turbo_frame_tag(dom_id(@success_criterion, :frame)) do
-  .d-flex
-    h2.my-2 Bearbeiten
-    .ms-auto
-      = success_criterion_menu(@success_criterion, false)
-      /= dropdown_menu(klass: "mt-3 b-0") do
-        ul.list-group
-          li.list-group-item
-            = success_criterion_edit_button(@success_criterion, true)
-          li.list-group-item
-            = button_to(tag.i(class: "bi bi-trash") + " Löschen".html_safe, @success_criterion, method: :delete, class: "btn text-danger", data: { turbo_confirm: "Bist du sicher?"})
-
-  .mb-3
-    = render "form", success_criterion: @success_criterion
-.action-row
-  = link_to t("scaffold.link_show", model: SuccessCriterion.model_name.human), @success_criterion
-  = link_to t("scaffold.link_index", model: SuccessCriterion.model_name.human(count: 2)), element_success_criteria_path(@success_criterion.element)
+h2 Erfolgskriterium bearbeiten
+.mb-3
+  = render "form", success_criterion: @success_criterion
+- unless modal?
+  .action-row
+    = link_to t("scaffold.link_show", model: SuccessCriterion.model_name.human), @success_criterion
+    = link_to t("scaffold.link_index", model: SuccessCriterion.model_name.human(count: 2)), element_success_criteria_path(@success_criterion.element)

app/views/success_criteria/update.turbo_stream.slim

@@ -3,5 +3,4 @@
 
 - @success_criterion.element.success_criteria.each do |sc|
   = turbo_stream.update(dom_id(sc, :position), sc.number)
-
-= turbo_stream_toast("Erfolgskriterium gespeichert: #{t("activerecord.attributes.success_criterion.results/#{@success_criterion.result}")}", false)
+= turbo_stream_toast("Erfolgskriterium gespeichert: #{t("activerecord.attributes.success_criterion.results/#{@success_criterion.result}")}", false)