Refactorings and gui improvements

test/system/elements_test.rb

@@ -13,13 +13,13 @@ class ElementsTest < ApplicationSystemTestCase
   end
 
   test "visiting the index" do
-    visit elements_url
+    visit page_elements_url(@element.page)
     assert_selector "h1", text: "Elemente"
   end
 
   test "should create element" do
     skip
-    visit elements_url
+    visit page_elements_url(@element.page)
     click_on "Element hinzufügen"
 
     assert_difference("Element.count", 1) do
@@ -35,9 +35,6 @@ class ElementsTest < ApplicationSystemTestCase
   test "should update Element" do
     visit element_url(@element)
     click_on "Element bearbeiten", match: :first
-
-    fill_in_rich_text_area "Details", with: @element.description_html
-    fill_in "Pfad", with: @element.path
     fill_in "Beschreibung", with: @element.title
     click_on "Element aktualisieren"
   end

test/system/pages_test.rb

@@ -3,45 +3,43 @@ require "application_system_test_case"
 class PagesTest < ApplicationSystemTestCase
   setup do
     @page = pages(:one)
+    login_test
+  end
+
+  teardown do
+    logout
   end
 
   test "visiting the index" do
-    visit pages_url
-    assert_selector "h1", text: "Pages"
+    visit report_pages_url(@page.report)
+    assert_selector "h1", text: "Pfade"
   end
 
   test "should create page" do
-    visit pages_url
-    click_on "New page"
+    visit report_pages_url(@page.report)
+    click_on "Pfad hinzufügen"
 
-    fill_in "Path", with: @page.path
-    fill_in "Position", with: @page.position
-    fill_in "Report", with: @page.report_id
+    fill_in "Name", with: @page.path
     fill_in "Url", with: @page.url
-    click_on "Create Page"
+    click_on "Pfad erstellen"
 
-    assert_text "Page was successfully created"
-    click_on "Back"
+    assert_text "Prüfbericht bearbeiten"
   end
 
   test "should update Page" do
     visit page_url(@page)
-    click_on "Edit this page", match: :first
+    click_on "Pfad bearbeiten", match: :first
 
-    fill_in "Path", with: @page.path
-    fill_in "Position", with: @page.position
-    fill_in "Report", with: @page.report_id
+    fill_in "Name", with: @page.path
     fill_in "Url", with: @page.url
-    click_on "Update Page"
-
-    assert_text "Page was successfully updated"
-    click_on "Back"
+    click_on "Pfad aktualisieren"
   end
 
   test "should destroy Page" do
     visit page_url(@page)
-    click_on "Destroy this page", match: :first
+    click_on "Pfad löschen", match: :first
 
-    assert_text "Page was successfully destroyed"
+    assert_text "Pfad hinzufügen"
+    assert(Page.exists?(@page.id) == false)
   end
 end

test/system/reports_test.rb

@@ -38,7 +38,7 @@ class ReportsTest < ApplicationSystemTestCase
   test "should destroy Report" do
     visit report_url(@report)
     click_on "Prüfbericht löschen", match: :first
-    assert_text("Report was successfully destroyed")
+    assert_text("Prüfberichte")
     assert(Report.exists?(@report.id) == false)
   end
 end

test/system/success_criteria_test.rb

@@ -8,21 +8,27 @@ class SuccessCriteriaTest < ApplicationSystemTestCase
   end
 
   setup do
+    @check = checks(:one)
+    @check.update!(name_de: "Testcheck")
     @success_criterion = success_criteria(:one)
+    @success_criterion.check = @check
+    @success_criterion.save!
     login_test
   end
 
   test "visiting the index" do
-    visit success_criteria_url
+    visit element_success_criteria_url(@success_criterion.element)
     assert_selector "h1", text: "Erfolgskriterien"
   end
 
   test "should create Erfolgskriterium" do
-    visit success_criteria_url
+    visit element_success_criteria_url(@success_criterion.element)
     click_on "Erfolgskriterium hinzufügen"
 
-    fill_in_rich_text_area "Testkommentar", with: @success_criterion.comment
-    fill_in_rich_text_area "Richtlinie", with: @success_criterion.description_html
+    select @check.name_de, from: "Check"
+
+    # fill_in_rich_text_area "Testkommentar", with: @success_criterion.test_comment
+    # fill_in_rich_text_area "Quick Kriterium", with: @success_criterion.quick_criterion
     # fill_in 'Element', with: @success_criterion.element_id
     # fill_in 'Level', with: @success_criterion.level
     # fill_in 'Result', with: @success_criterion.result
@@ -34,8 +40,8 @@ class SuccessCriteriaTest < ApplicationSystemTestCase
     visit success_criterion_url(@success_criterion)
     click_on "Erfolgskriterium bearbeiten", match: :first
 
-    fill_in_rich_text_area "Testkommentar", with: @success_criterion.comment
-    fill_in_rich_text_area "Richtlinie", with: @success_criterion.description_html
+    fill_in_rich_text_area "Testkommentar", with: @success_criterion.test_comment
+    fill_in_rich_text_area "Quick Kriterium", with: @success_criterion.quick_criterion
     find("label", text: "Bestanden", visible: true).click
     fill_in "Titel", with: "new"
     click_on "Erfolgskriterium aktualisieren"